search

trezor / trezor-suite

Trezor Suite Monorepo
https://trezor.io/trezor-suite
Other
674 stars 242 forks source link

TypeError: target property is non-configurable and non-writable, and get trap result differs from target pro... #8639

Open sentry-io[bot] opened 1 year ago

sentry-io[bot] commented 1 year ago

Sentry Issue: SUITE-NATIVE-3Q

TypeError: target property is non-configurable and non-writable, and get trap result differs from target property value
  at memoizeWithArgs$argument_0 (/Users/runner/work/trezor-suite/trezor-suite/suite-native/ethereum-tokens/src/ethereumTokensSelectors.ts:96:38)
  at selectAccountOrTokenAccountTransactions (/Users/runner/work/trezor-suite/trezor-suite/suite-native/ethereum-tokens/src/ethereumTokensSelectors.ts:135:60)
  at useSelector$argument_0 (/Users/runner/work/trezor-suite/trezor-suite/suite-native/module-accounts/src/screens/AccountDetailScreen.tsx:40:52)
  at memo$argument_0 (/Users/runner/work/trezor-suite/trezor-suite/suite-native/module-accounts/src/screens/AccountDetailScreen.tsx:38:44)
...
(36 additional frame(s) were not displayed)
PeKne commented 1 year ago

The error is happening in the selectAccountTransactions selector, exactly this line: https://github.com/trezor/trezor-suite/blob/ffd0b4da8703dc477fd734d456d18ce79fd41c49/suite-common/wallet-core/src/transactions/transactionsReducer.ts#L175 After some debugging, the memorization seem to be the root of the problem. But why? need to investigate more.

juriczech commented 1 year ago

Should be fixed by https://github.com/trezor/trezor-suite/issues/8552

If not, we will investigate more and find a better fix

Nodonisko commented 1 year ago

@juriczech Why do you think it's related? Seems like totally unrelated issue, are sure you linked correct issue?

PeKne commented 1 year ago

solved by #8659

Nodonisko commented 1 year ago

Only hotfixed. We should open proper issue in proxy-memoize repo, because we want to upgrade lib in future.