search

trezor / trezor-suite

Trezor Suite Monorepo
https://trezor.io/trezor-suite
Other
721 stars 251 forks source link

Ensure compatibility of Suite Web with supported browsers #8833

Open matejkriz opened 1 year ago

matejkriz commented 1 year ago

If we use some language feature, that is not compatible with all browsers we support according to browserlist config, we should be warned.

Or we can consider adding @babel/preset-env transformation for Suite Web.

tomasklim commented 1 year ago

We can consider this https://www.npmjs.com/package/eslint-plugin-compat

AdamSchinzel commented 1 year ago

We had a discussion with @matejkriz and it is harder to add this plugin than it seems because it requires this code in .eslintrc.js:

"env": {
    "browser": true
 }

We can't add this to the root .eslintrc.js file so it must be handled separately for each package (also check where this packages is used, if it is relevant etc.).

This requires further research and right now not high priority, we can do it sometime later.