trezor / trezor-suite

Trezor Suite Monorepo
https://trezor.io/trezor-suite
Other
723 stars 251 forks source link

PIN change or setup of model One broken when using computer keyboard #9265

Open bosomt opened 1 year ago

bosomt commented 1 year ago

Describe the bug See both videos, first for PIN setup and second for PIN change. When you confirm PIN via computer keyboard then in second dialogue there is always one character already in PIN field. I was able to replicate on dev version and on production version.

Steps to reproduce:

  1. Try to change or set PIN code on model One
  2. Confirm PIN via enter on keyboard
  3. Observe modal behavior, there is always one character pre-filled.

Info:

Screenshots:

https://github.com/trezor/trezor-suite/assets/31506317/0e1f3cff-4a31-4c19-8b96-d5720209f220

https://github.com/trezor/trezor-suite/assets/31506317/20ad67ea-066e-4229-9137-617a511c24ac

matejkriz commented 1 year ago

@Hermez-cz How about making it impossible to enter PIN from the keyboard? Not to solve this bug, but because it makes the blind matrix meaningless and the user can unnecessarily reveal the PIN. But I guess that would complicate the the work of our @trezor/qa?

Hannsek commented 1 year ago

Didn’t know this was possible. I would restrict it. 🤷🏻‍♂️