search

trezor / trezor-suite

Trezor Suite Monorepo
https://trezor.io/trezor-suite
Other
720 stars 250 forks source link

Blurred screen overlay bugs #9955

Open PeKne opened 11 months ago

PeKne commented 11 months ago

Describe the bug After reintroducing blurred screen overlays back to the app, multiple bugs were spotted.

  1. If are biometrics disabled and user leaves the app, the overlay is not displayed at all.
  2. On some android devices, the overlay does not cover the full height of the screen, and there is a "unblurred" part at the bottom of the screen.
  3. If you scroll and trigger the overlay (leave the app, open the bottom sheet etc.) the overlay represents the screen at its unscrolled state

Overlays under the bottom sheets makes weird design jump due to different underlaying screen - look at the video: https://drive.google.com/file/d/1U2eW4u7e7obyv13aSz1l0czcrWo91L3W/view?usp=drive_link

PeKne commented 11 months ago

Blocked by underlying skia problem: https://github.com/Shopify/react-native-skia/discussions/2013

PeKne commented 11 months ago

Due to the mentioned bug, we will revert the overlays until the underlying skia error is resolved.

matejkriz commented 9 months ago

Even if the bug in skia is resolved, it is not certain that we want the blur on the overlay. Confirm with the designer before changing anything.