gometalinter: CloseNotifier deprecated

[prusnak]

server/api/api.go:71:15:warning: http.CloseNotifier is deprecated: the CloseNotifier interface predates Go's context package. New code should use Request.Context instead.  (SA1019) (staticcheck)
server/api/api.go:202:15:warning: http.CloseNotifier is deprecated: the CloseNotifier interface predates Go's context package. New code should use Request.Context instead.  (SA1019) (staticcheck)

[karelbilek]

Fixing this will maybe break old go versions that we still support. (but I haven't looked that hard)

On Fri, Feb 15, 2019, 7:16 AM Pavol Rusnak <notifications@github.com wrote:

server/api/api.go:71:15:warning: http.CloseNotifier is deprecated: the CloseNotifier interface predates Go's context package. New code should use Request.Context instead. (SA1019) (staticcheck) server/api/api.go:202:15:warning: http.CloseNotifier is deprecated: the CloseNotifier interface predates Go's context package. New code should use Request.Context instead. (SA1019) (staticcheck)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/trezor/trezord-go/issues/138, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGZ8Ts_NL2LykUjgPVelUITF5IiUMPlks5vNfxDgaJpZM4a8sVq .

[prusnak]

I am fine with keeping this as is. Just created an issue, so we know why the gometalinter test is failing.

[karelbilek]

My own q/a on SO :)

https://stackoverflow.com/questions/54890809/how-to-use-request-context-instead-of-closenotifier/54890870#54890870

[prusnak]

So is this change backwards compatible or in case it is not, how old versions will this break?

[karelbilek]

Looking at travis results from #146 and the go release notes, it seems it was introduced in 1.7; so all our tests are still working and #146 can be merged

[karelbilek]

Fixed by #146