search

trezor / trezord-go

:smiling_imp: Trezor Communication Daemon (written in Go)
GNU Lesser General Public License v3.0
245 stars 146 forks source link

Decrease the waiting time for emulator #174

Closed tsusanka closed 4 years ago

tsusanka commented 5 years ago

Currently, when you run trezord with support for emulator (e.g. trezord-go -e 21324) and the emulator is not running the user is experiencing lags (~5s per device discovery) because trezord is waiting for the emulator. This makes it somewhat unusable to use it permanently - in other words, the goal is to have trezord-go running in the background which supports both devices and emulators right out of the box.

I believe the concerned line is: https://github.com/trezor/trezord-go/blob/1ff6715175ef4add89052cd6d7d181b1a5d7af5a/usb/udp.go#L23

@prusnak @karel-3d do you see any reasons not to decrease this value to 1s for example? Is it too low?

prusnak commented 5 years ago

By digging in the git history I found out that the last value of 700ms was not enough for Trezor One(!) emulator on macOS. I'd say let's decrease this to 500ms and test if this is still the case on macOS.

tsusanka commented 5 years ago

Great. Will do a branch and test on Szymon's mac

tsusanka commented 4 years ago

Since Szymon had some difficulties on MacOS we have agreed to do an if branch and use 5000 for Mac and 700 elsewhere. We need to test this change properly including Windows.

I will modify #175 appropriately.

tsusanka commented 4 years ago

Merged via 55e66adbdb5791175c13a015028cd8ca4cf8fbc5. I finally went for 500 for non-mac OS as @prusnak mentioned. It seems it should be fine, but we need to test this extensively on all three platforms.