trezor / trezord-go

:smiling_imp: Trezor Communication Daemon (written in Go)
GNU Lesser General Public License v3.0
244 stars 146 forks source link

MacOS release candidate installation fails #194

Closed sorooris closed 4 years ago

sorooris commented 4 years ago

Describe the bug Installing the Bridge 2.0.30 RC3 ends in an error.

App version and revision Bridge 2.0.30 RC3 (bff32065)

Setup:

To Reproduce Steps to reproduce the behavior:

  1. Start the install wizard
  2. Navigate through the steps
  3. See error

Expected behavior Installation ends successfully.

Screenshots N/A

Additional context The machine has developers apps allowed.

tsusanka commented 4 years ago

What error it prints? Or it crashes?

tsusanka commented 4 years ago

Might be related to https://github.com/trezor/trezord-go/commit/4e5a0d35e42b316bee0a854bc965805838b9ab71

prusnak commented 4 years ago

Might be related to 4e5a0d3

@tsusanka Can you try reverting the commit whether this helps?

sorooris commented 4 years ago

@tsusanka Nothing specific:

The installation failed. The installer encountered an error that caused the installation to fail. Contact the software manufacturer for assistance. image

Attempt at closing the window with the X button displays a dialog with a Show error option; however selecting it does not trigger any apparent action.

image

tsusanka commented 4 years ago

Sent a new version via Asana, GH doesn't allow .pkg files. Please retest.

sorooris commented 4 years ago

@tsusanka Tested the 8a597a revision, reported in Asana; however I've encountered a similar issue to #186 - details are in the comment there.

The issue I'm referencing is with the Uninstall wizard - it seemingly fails in the last step (the same vague way as the installation did in revision bff3206) but is in fact removed after restarting the machine; this behavior can be confusing for users and definitely was to me at first.

tsusanka commented 4 years ago

@prusnak how do we want to approach this? Should I revert the commit in master or do you want to try nixifying this? :)

prusnak commented 4 years ago

If the revert fixes the installation, let's do it.

Nixification is in my pipeline, but let's not block the release with this.