search

trezor / trezord-go

:smiling_imp: Trezor Communication Daemon (written in Go)
GNU Lesser General Public License v3.0
244 stars 146 forks source link

Insufficient revision information for QA #203

Closed sorooris closed 3 years ago

sorooris commented 3 years ago

Describe the bug Running the standard local address + port displays only the version, not revision, which is relevant and important for dev + QA cooperation.

App version and revision Bridge 2.0.30 RC5 (apparent here)

Setup: OS: MacOS Catalina 10.15.7

Steps to reproduce:

  1. Open the standard Bridge local address + port 127.0.0.1:21325
  2. Observe.

Expected behavior: Clickable link to commit hash (similar to Suite) is present.

Actual behavior: Only general version (2.0.30) is displayed on the page.

Screenshot: image

prusnak commented 3 years ago

Partially addressed in c79d1145ef3a26fbb08ef5c5ff42481d4fc21ae5

We still need to update release scripts to override githash during build via

go build -ldflags="-X 'main.githash=$(git rev-parse --short HEAD)'"
prusnak commented 3 years ago

More stuff added in 1c5405b6aea08e6a1dd39704a0f923d2e6d992f1 which closes the issue