trezor / trezord-go

:smiling_imp: Trezor Communication Daemon (written in Go)
GNU Lesser General Public License v3.0
244 stars 146 forks source link

Windows: Device in bootloader mode not detected #210

Closed sorooris closed 3 years ago

sorooris commented 3 years ago

Describe the bug: Device is detected as long as it is in the normal mode, reconnecting it in bootloader mode renders it undetectable by Bridge 2.0.30 - does not occur with 2.0.29 and older.

App version and revision: Bridge 2.0.30 public

Setup: OS: Windows 10.0.19041.572 Browser: Firefox 82.0, 83.0; Chrome 86.0.4240.111, 87.0.4280.66 Device: any firmware (tested model T 2.3.1, 2.3.4; T1 1.8.3, 2.3.1)

Steps to reproduce: Prerequisite - Bridge 2.0.30 installed

  1. Navigate to Suite/MyTrezor wallet,
  2. Reconnect device in bootloader mode.

Expected behavior: Device is detected when in bootloader mode.

Actual behavior: 0 connected devices displayed in 127.0.0.1:21325 and both Suite and MyTrezor Wallet connect device prompt/modal displayed.

Screenshot: N/A

prusnak commented 3 years ago

Is it just Windows or macOS/Linux as well?

bosomt commented 3 years ago

KUbuntu works fine, i was able ton install firmware in bootloader mode, both browsers and bridge see devices

QA OK

KUbuntu 20.03 Chrome 86 + Firefox 82.0.3 Trezor Bridge 2.0.30 /fresh install/ T1 + TT

image

sorooris commented 3 years ago

@prusnak macOS QA OK

Setup: OS: macOS Big Sur 11.0.1 Browsers:

bosomt commented 3 years ago

QA NOK

Connected devices 0

Windows 10.0.19042.630 Chromium and Firefox, current versions Fresh install of 2.0.30 T1 + TT in BL mode

tsusanka commented 3 years ago

OS: Windows 20.0.19041.572

@sorooris you mean Windows 10 not 20 right?

tsusanka commented 3 years ago

@wendys-cats could you please retest this on your Win 10?

sorooris commented 3 years ago

@tsusanka sorry :man_facepalming: yes of course

OS: Windows 20.0.19041.572

@sorooris you mean Windows 10 not 20 right?

wendys-cats commented 3 years ago

QA NOK

OS Windows 10 home 2004 19041.630

devices (tested TT 2.3.4 and T1 1.9.3)

Chrome Version 87.0.4280.66 (Official Build) (64-bit) NOK??? Chrome itself DID detect device in bootloader mode - a chrome pop up notification showed up and upon clicking, redirected the user to trezor.io web. But neither Suite nor Wallet detected device in bootloader mode.

Chrome Version 86 NOK

Firefox 83.0 NOK

tsusanka commented 3 years ago

Detailed logs from my testing Windows. All from a fresh install of trezord.

tsusanka commented 3 years ago

There is a new version of hidapi 0.10.1. I guess we can try to upgrade even though the release notes do not mention anything related on a first sight, so it is a long shot. We are using 0.10.0 in 2.0.30.

tsusanka commented 3 years ago

Ad libusb: I am wondering if this commit could help by any chance.

prusnak commented 3 years ago

master updated to latest libusb and hidapi, but the problem still persists

prusnak commented 3 years ago

Fixed in https://github.com/trezor/trezord-go/commit/5438e38dd37f8865e2ad27840480c7f81c1edfff + https://github.com/trezor/trezord-go/commit/bcdcefcba28d8cccd45fe3e9d1cfb0f172071025

Signed binaries for testing will be available soon(tm)