trezor / trezord-go

:smiling_imp: Trezor Communication Daemon (written in Go)
GNU Lesser General Public License v3.0
244 stars 146 forks source link

macOS native apple silicon arm packaging and homebrew support #235

Closed McCodeman closed 1 year ago

McCodeman commented 2 years ago

Feature Request

I would like to run trezord independently as a native apple silicon (arm) process.

Problem

If I install trezor-bridge from the homebrew cask, an Intel compatible (using Rosetta) trezord process is started. If I run Trezor Suite w/o the trezor-bridge installed, a native apple silicon trezord process is started.

Ask

I'd like to use Trezor with native apple silicon trezord process w/o having to launch Trezor Suite. Can macOS trezord packaging be updated to include an arm variant and have home brew cask installation select this variant?

Mitigation

I can use the Intel version until this becomes available or just launch Trezor Suite. I'm willing to help but very new to this project and may need some pointers on build and packaging process.

Thanks for creating a great product!

prusnak commented 2 years ago

Can macOS trezord packaging be updated to include an arm variant and have home brew cask installation select this variant?

This is becoming more and more problematic with new Apple requirements for notarization.

I think it makes more sense to rewrite the Trezor Bridge cask so it builds the bridge from the source. Are you up for this task?

McCodeman commented 2 years ago

I think it makes more sense to rewrite the Trezor Bridge cask so it builds the bridge from the source. Are you up for this task?

Sure. Let me first attempt to build it locally on macOS.

igor-hnizdo commented 2 years ago

When removing xgo for mac, I added also ARM support

https://github.com/trezor/trezord-go/pull/258

the notarization thing is not included

igor-hnizdo commented 2 years ago

I have included notarization too. I am closing this as it's done in master even when it's not yet released, but will be soon-ish.

igor-hnizdo commented 2 years ago

Ah, the issue included homebrew too. Reopening.

prusnak commented 1 year ago

Homebrew PR in https://github.com/Homebrew/homebrew-core/pull/111672

prusnak commented 1 year ago

Homebrew PR has been merged