trezor / trezord-go

:smiling_imp: Trezor Communication Daemon (written in Go)
GNU Lesser General Public License v3.0
246 stars 148 forks source link

fix(linux): remove /var/log/trezord.log creation #255

Closed aloisklink closed 2 years ago

aloisklink commented 2 years ago

As far as I'm aware, Linux has never logged to /var/log/trezord.log (I did a quick search through git blame and couldn't find anything).

Because of that, there's no reason to even create the /var/log/trezord.log file.

On my PC, ls -lhrt /var/log/trezord.log shows that it has 0 bytes, and has been unmodified since 2021.

user@computer:~$ sudo ls -lhrt /var/log/trezord.log 
-rw-rw---- 1 trezord trezord 0 Oct 17  2021 /var/log/trezord.log

Instead, Linux just relies on systemd's logger. On most new devices, you can view these logs via journalctl -u trezord.

I'm 99.9% sure this will fix #245 and fix #246, but I don't run Fedora or Fedora Silverblue, so it might be worth @hegjon or @triceo testing (if they're still interested)

prusnak commented 2 years ago

You are right. We used to log to that file, but this is no longer happening.