search

trezor / trezord-go

:smiling_imp: Trezor Communication Daemon (written in Go)
GNU Lesser General Public License v3.0
245 stars 148 forks source link

Clean makefiles, move GPG signing to release.sh #269

Closed igor-hnizdo closed 2 years ago

igor-hnizdo commented 2 years ago

I have cleaned up the makefiles. I have also moved the GPG signing to the individual releases and out of existing Makefile.

Also I read the GPG key out of GPG instead of hard-coding it.

The negative is that now we require quite a lot of keys to set up... especially the macos now needs tons of keys.

I will try to document them all somewhere.

igor-hnizdo commented 2 years ago

Fixed

tsusanka commented 2 years ago

I get an error for make in release/ because I do not have the certs. Could you please change it that it does not sign when there are no such files?

I think you forgot this but I am gonna merge and go through it all after we merge all the PRs and text and fix so you do not have fix these tiny nits all the time.

igor-hnizdo commented 2 years ago

OK I will see if it's still doing that. I thought I fixed that by Makefile changes

igor-hnizdo commented 2 years ago

I have tested it and it works without the keys

tsusanka commented 2 years ago

I am getting this on 073154d5dea5d40b7c35f1b9b63dcfb8ca92e711:

+ rcodesign sign --p12-file /release/certs/app.p12 --p12-password-file /release/certs/app.passphrase --code-signature-flags runtime /release/build/trezord
Error: I/O error: No such file or directory (os error 2)
make[1]: *** [.package] Error 1
make: *** [macos] Error 2

It seems it is the one for macOS.

igor-hnizdo commented 2 years ago

ahh it's not the GPG stuff, but something else. OK will check that

tsusanka commented 2 years ago

Oh yeah, sorry it is the certs.