Closed igor-hnizdo closed 1 year ago
We don't need the following files, so please remove then from the PR:
usb/lowlevel/libusb/c/Makefile*
usb/lowlevel/libusb/c/libusb-1.0.def
usb/lowlevel/libusb/c/libusb-1.0.rc
usb/lowlevel/libusb/c/os/haiku*
usb/lowlevel/libusb/c/os/linux_udev.c
usb/lowlevel/libusb/c/os/netbsd_usb.c
usb/lowlevel/libusb/c/os/null_usb.c
usb/lowlevel/libusb/c/os/openbsd_usb.c
usb/lowlevel/libusb/c/os/sunos_usb.c
usb/lowlevel/libusb/c/os/sunos_usb.h
OK. Also the instructions are a bit wrong, will update them
Fixed, please review again and possibly merge
@tsusanka
windows_open
Those are the 4 things we need custom code for.
Ah, no, 1. and 2. are the same thing.
We detect missing WinUSB driver and then skip this device.
If we don't have this code, Trezor with missing WinUSB driver shows in listing, but then it errors on read/write with some mysterious error.
It's issue with Windows and WinUSB. It was mostly an issue on older Windows (7, Vista), but I remember it can potentially be an issue in Win10.... maybe? I don't remember.
Yeah it was only issue with 7 and Vista.
If we don't care about Windows 7 and Vista, we can remove the custom code with has_winusb_driver
, and also remove a lot of other cruft.
(The wdi-simple.exe can definitely can be removed, as that is run only when user has Windows 7 or Vista.)
Windows 7 is officially not supported by even Microsoft anymore, but, it still has more marketshare than all MacOS versions together. (Let alone all Linux versions together.)
It's your call if you want to cut the support :)
Let's move it here
Great info, thx 👍 .
Also add documentation on how to update