search

trezor / trezord-go

:smiling_imp: Trezor Communication Daemon (written in Go)
GNU Lesser General Public License v3.0
241 stars 146 forks source link

Remove trezorv2 from HIDAPI #290

Closed karelbilek closed 1 year ago

karelbilek commented 1 year ago

Fixes #288

karelbilek commented 1 year ago

Please check if the ancient trezors with HID still work after this. But I don't see why they might not.

karelbilek commented 1 year ago

The only part it really touches is listing of devices. So if devices are listed properly - both T1, TT and old HID T1 - on all OSes - then all is fine.

karelbilek commented 1 year ago

Sorry, no need to test Linux, hidapi is not used on linux.

bosomt commented 1 year ago

@karelbilek already testing new version

i see that old devices with ancient bootloaders 1.3.2 or 1.3.2 are listed in trezorctl or in Bridge status page twice /only in normal mode, in bootloader i see only one device.

image 
 ~  trezorctl list                                                                                                                                                   
bridge:5 - Device is in use by another process
/opt/homebrew/lib/python3.10/site-packages/trezorlib/client.py:280: UserWarning: Firmware is out of date
  self.check_firmware_version(warn_only=True)
bridge:6 - Failed to read details
 ~  trezorctl list                                                                                                                                                  
bridge:7 - Trezor 1 bootloader
tsusanka commented 1 year ago

If 1.3.2 is the only troublesome FW / BL I think we can live with that.

bosomt commented 1 year ago

retested with newer fw 1.7.1/1.6.1 and it works as expected on macARM and on Win10 platforms.