Closed nekoteoj closed 8 months ago
Hey @nekoteoj thanks for the contribution.
Does this PR resolve #297 ?
Hey! Thanks for reviewing!
I think the error when building the docker image is the same as #297 due to golang 1.21. This PR doesn't resolve #297 since I only edited the Dockerfile. This PR changed the golang image version to 1.18 so the docker image could still be built (I think this is more like a workaround for building the image while we still cannot build the repo using golang 1.21). I also edit the build script in the Dockerfile since go get
cannot run outside of go module directory now.
Also, the compiled trezord-go
executable from the docker image run fine on my host os (Void Linux). So I think this can be used as an alternative build method for system with golang version >= 1.21 too.
Yes, and the other reason is that I saw the github workflow used go 1.18 in check-go-validation.yml
.
Problem: The current Dockerfile doesn't work when building the image. Consequently, the Docker compose file also doesn't work. This problem is caused by following issues.
usb/lowlevel/libusb/libusb.go
with these error messages.go get
outside of the go module directory. However,go get
is no longer supported outside a module.Solution:
go get
to get the source code in the image, the whole repository is copied to the image. Previously, only the run script was copied to the image.