search

trezy / next-safe

https://trezy.gitbook.io/next-safe/
BSD 3-Clause "New" or "Revised" License
167 stars 20 forks source link

Built-in type declarations #30

Closed marconms closed 2 years ago

marconms commented 2 years ago

Is your feature request related to a problem? Please describe.

The first time I encountered the package, I expected to use it with built-in type declarations.

Describe the solution you'd like

It would be nice to see declarations added.

Describe alternatives you've considered

There's no real alternatives for implementing Typescript types 😅

Additional context

The creation of a simple types.d.ts would suffice, it should be quick to implement while keeping JavaScript as the main language.

Code of Conduct

trezy commented 2 years ago

Hmm... tsd-jsdoc should be generating types with the published package. I'll look into this and see what I can figure out.

marconms commented 2 years ago

Right, double-checking in the NPM page, it does seem to contain type declarations; they don't show up for me, though. I'll investigate a bit more, it may be just a problem from my end, I didn't realize.

trezy commented 2 years ago

Installing the latest version of the lib, I'm not actually getting the types. As it turns out, I created the build-types Yarn script, but I never actually implemented it for the release. 🤦🏻‍♂️

I'll get this fixed here shortly.

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version 3.2.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: