search

trganda / obsidian-attachment-management

Attachment Management of Obsidian
MIT License
168 stars 11 forks source link

feat: add webp image support and parent as a variable name #12

Closed Mara-Li closed 1 year ago

Mara-Li commented 1 year ago

Spotted that webp wasn't in image support, so I added it :D

(cf https://help.obsidian.md/Advanced+topics/Accepted+file+formats)

I also simplified some expression

Mara-Li commented 1 year ago

I updated the FR to add #7. Must be tested & reviewed before merge, I'm not pretty sure about my implementation of parent!

Mara-Li commented 1 year ago

I want to add that your plugin is very cool. I hope my PRs and suggestions are not considered as spam. I dreamed of your plugin a lot, because I have a lot of attachments and it's a mess to use with Obsidian. Your plugin will change my way to handle these :)

trganda commented 1 year ago

I want to add that your plugin is very cool. I hope my PRs and suggestions are not considered as spam. I dreamed of your plugin a lot, because I have a lot of attachments and it's a mess to use with Obsidian. Your plugin will change my way to handle these :)

Thk for your PR first! I have a little busy these day, and don't' worry about that your PR will be considered spam. And I will review your code today

Mara-Li commented 1 year ago

Can you check the changes ? :D