feat: proposition for keeping original file name

trganda / obsidian-attachment-management

Attachment Management of Obsidian

MIT License

168 stars 11 forks source link

Closed Mara-Li closed 1 year ago

Mara-Li commented 1 year ago

See #10.

My idea:

Keep the original name (easy)
When creating the new name, replace ${originalname} with the original name + a key.
This key is a constant, I needed to prevent false positive duplicate found.
As I don't have an idea for the key, I choose to create a constant, so we can change it whenever we want, for something better.
The key is replaced in the final renaming and message information.

trganda commented 1 year ago

Hi, @Lisandra-dev, tks for your PR. I will merge it first, and release it asap.

Btw, I have no develop this feature currently, because I want to add another feature described in discussion https://github.com/trganda/obsidian-attachment-management/discussions/21 first. But I have delayed a fews day.

Tips:

You can use const { name } = deduplicateNewName(attachName, attachPath) to prevent the false positive duplicate. I will add more comments for it.