search

trganda / obsidian-attachment-management

Attachment Management of Obsidian
MIT License
144 stars 8 forks source link

refactor(log): fix undefined when loading plugin (use manifest…) #8

Closed Mara-Li closed 1 year ago

Mara-Li commented 1 year ago

For some reason (I'm not pretty sure), I needed to reload the settings after their saving in the overriding.

trganda commented 1 year ago

For safety, we should save and reload the setting everytime when set or reset. I have forgot to reload the setting after submit.

trganda commented 1 year ago

Btw, for the Reset command, maybe we should use await (save and reload) as the callback of Reset button?

In the previous PR, you have remove the await (save and reload), any reason? (This may leading error setting I think)

Mara-Li commented 1 year ago

You don't need to await in a checkCallback() (my testing around this doesn't make problem, as in my other plugin)

trganda commented 1 year ago

You don't need to await in a checkCallback() (my testing around this doesn't make problem, as in my other plugin)

Tks for your tips, I have test it and evertything is ok.