Update barRender.ts - Githubissues

trgkanki / remaining_time

GNU Affero General Public License v3.0

17 stars 3 forks source link

Update barRender.ts #11

Closed thiswillbeyourgithub closed 4 years ago

thiswillbeyourgithub commented 4 years ago

changed the reset confirmation string, otherwise you don't know what addons is asking to reset and it is scary

ps : congrat on the rewriting, thanks a lot!

phu54321 commented 4 years ago

Due to some isues I've independently merged the PR to my branch.

No direct PR to master branch. All should go to develop branch.
Gitmoji for commit messages. (Search for gitmoji-cli or so)
(This is just my taste) minor confirm message adjustment.

Maybe I should create CONTRIBUTING file for these instructions. Thanks for the PR & idea!

thiswillbeyourgithub commented 4 years ago

No worries, I'm not all that familiar with PR's good practice and I did it in a rush...

Btw, on this page : https://ankiweb.net/shared/info/1508357010 the link leads to the former repo, and not to the page that says that the repo is outdated. It confused me quite a bit.

edit : didn't know about gitmoji, thanks a lot!