trias-project / indicators

📈 Alien species indicators
https://trias-project.github.io/indicators/
MIT License
0 stars 1 forks source link

Update Belgian occurrence indicators based on corrected cubes #128

Closed damianooldoni closed 1 month ago

damianooldoni commented 3 months ago

Run occurrence based indicators on corrected cubes:

This means running all Rmds in ./src from 5 to 12.

soriadelva commented 3 months ago

Update: the links to the corrected cubes on zenodo have been added where necessary. However, two errors occurred

damianooldoni commented 3 months ago

First problem solved via c6e5763

soriadelva commented 3 months ago

@damianooldoni I tried to rerun the 07_occurrence_indicators_modelling.Rmd script but still encountered the same error linked to the apply_gam function (column smooth doesn't exist). It has likely something to do with how I loaded the updated version of the trias package on my local computer (I fetched the main branch of trias-project/trias and did "update from main" in Github Desktop for the current branch linked to issue #128 of trias-project/indicators). As that still gave an error, I updated the trias package on my local computer but that also didn't work. Do you know if I still need to do something else? Thanks in advance!

damianooldoni commented 3 months ago

Hi @soriadelva. The trias branch with the update was still not merged to main. That was indeed my task to do after your review. I have just merged to main. You could now via GitHub Desktop:

  1. go to trias repository
  2. check you are on main branch
  3. click on "fetch origin"
  4. Pull the changes
  5. Open tias RStudio project related to trias R package
  6. Run devtools::install()
  7. Close it
  8. Open indicator R project or close it and open it again.
  9. Run library(trias)
  10. Check you have the right package version by running devtools::session_info(). If you see a line with trias * 2.1.0 it's ok.

So, in general, it's just a question of checking versions of a package. This is a nice example why it's important to apply versioning in package development 😄

Please, don't hesitate to contact me here or via chat if something is not working or not clear.

soriadelva commented 3 months ago

Hi @soriadelva. The trias branch with the update was still not merged to main. That was indeed my task to do after your review. I have just merged to main. You could now via GitHub Desktop:

  1. go to trias repository
  2. check you are on main branch
  3. click on "fetch origin"
  4. Pull the changes
  5. Open tias RStudio project related to trias R package
  6. Run devtools::install()
  7. Close it
  8. Open indicator R project or close it and open it again.
  9. Run library(trias)
  10. Check you have the right package version by running devtools::session_info(). If you see a line with trias * 2.1.0 it's ok.

So, in general, it's just a question of checking versions of a package. This is a nice example why it's important to apply versioning in package development 😄

Please, don't hesitate to contact me here or via chat if something is not working or not clear.

Thanks @damianooldoni, this worked! I ran all scripts and knit the respective .Rmd files. Before I generate a Pull Request, do you want me to commit all the files that have been overwritten by the changes?

damianooldoni commented 3 months ago

Did you remember to delete all existent images before generating the new ones?

Yes, you can push the changes in some commits and then generate a Pull Request 👍 Thanks a lot.

soriadelva commented 3 months ago

Did you remember to delete all existent images before generating the new ones?

Yes, you can push the changes in some commits and then generate a Pull Request 👍 Thanks a lot.

oh no, I didn't! 😓 I'll run it again!!