search

trias-project / risk-maps

🗺 Web application to browse risk maps
https://trias-project.github.io/risk-maps/
MIT License
1 stars 1 forks source link

Implement scale #2

Closed niconoe closed 4 years ago

niconoe commented 4 years ago

0-1, description given by Amy at https://github.com/trias-project/risk-modelling-and-mapping/issues/7

niconoe commented 4 years ago

Update now implemented a color scale that's closer to Amy's suggestion. Opinions about it?

niconoe commented 4 years ago

@amyjsdavis: I now implemented a different color scale, do you have an opinion about it?

Screenshot 2020-04-09 at 13 41 01

For info, I can very easily configure any of the color schemes presented at: https://github.com/d3/d3-scale-chromatic

I can obviously also implement something custom, we'll just need some discussion to make sure we understand each other about how that scale works!

amyjsdavis commented 4 years ago

This is the typical scale used for a lot of heat maps and the one I prefer, because it is intuitive with red typically representing "hot" or "high" and blue representing cold or low. Perhaps you accidentally reversed the places of 0 and 1? For the species I have sent so far, Flanders has been more at risk then Wallonia.

On Thu, Apr 9, 2020 at 1:45 PM Nicolas Noé notifications@github.com wrote:

@amyjsdavis https://github.com/amyjsdavis: I now implemented a different color scale, do you have an opinion about it?

[image: Screenshot 2020-04-09 at 13 41 01] https://user-images.githubusercontent.com/386387/78891465-e5921e00-7a67-11ea-80f0-1e0828d571a7.png

For info, I can very easily configure any of the color schemes presented at: https://github.com/d3/d3-scale-chromatic

I can obviously also implement something custom, we'll just need some discussion to make sure we understand each other about how that scale works!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/trias-project/risk-maps/issues/2#issuecomment-611484300, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC4KXBXX56ZXMSFARDEYYOLRLWYMNANCNFSM4KXVKNSA .

-- Dr. Amy J.S. Davis Data-driven solutions to invasive species and biodiversity conservation

Terrestrial Ecology Unit Department of Biology Ghent University K. L. Ledeganckstraat 35 B-9000 Ghent Belgium http://amyjsdavis.com

qgroom commented 4 years ago

This is the typical scale used for a lot of heat maps and the one I prefer, because it is intuitive with red typically representing "hot" or "high" and blue representing cold or low. Perhaps you accidentally reversed the places of 0 and 1? For the species I have sent so far, Flanders has been more at risk then Wallonia.

This is the first thing I thought too.

niconoe commented 4 years ago

Thanks @amyjsdavis abd @qgroom !

I now configured this color ramp, which looks closer to yours (and is reversed: red for high risk is indeed much more clear).

Can you have a look at https://trias-project.github.io/risk-maps/ and tell me what you think?

qgroom commented 4 years ago

It looks great, but I do have a couple of queries... It is a bit odd having 1 at the bottom of the scale legend I'm not really clear on the confidence. Does 1 mean we have high confidence in the prediction? I assume so. In that case we perhaps want the colour ramp the opposite way around to the risk map itself.

niconoe commented 4 years ago

Thanks @qgroom, I now updated the legend so "1" is indeed on top. I guess that's a step in the right direction!

amyjsdavis commented 4 years ago

@niconoe : It looks great!

niconoe commented 4 years ago

Is everyone reasonably happy with the current implementation? If so, I suggest closing this issue (we can create new ones if specific issues arises!)

amyjsdavis commented 4 years ago

I am happy with it.

On Fri, Jun 5, 2020 at 10:01 AM Nicolas Noé notifications@github.com wrote:

Is everyone reasonably happy with the current implementation? If so, I suggest closing this issue (we can create new ones if specific issues arises!)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/trias-project/risk-maps/issues/2#issuecomment-639323630, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC4KXBUB5ZNW3NOVGZIMSRTRVCQ4ZANCNFSM4KXVKNSA .

-- Dr. Amy J.S. Davis Data-driven solutions to invasive species and biodiversity conservation

Terrestrial Ecology Unit Department of Biology Ghent University K. L. Ledeganckstraat 35 B-9000 Ghent Belgium http://amyjsdavis.com