search

trias-project / trias

R package with functionality for TrIAS and LIFE RIPARIAS
https://trias-project.github.io/trias
MIT License
3 stars 1 forks source link

should `pathways_cbd()` be a function? #134

Open PietrH opened 3 months ago

PietrH commented 3 months ago

Currently pathways_cbd() is a function that accepts no arguments, and always returns the same tibble. Woudn't it be better to include this tibble as a data object?

https://usethis.r-lib.org/reference/use_data.html

https://github.com/trias-project/trias/blob/98ef3f2afacdd506ed54d3ba42891c8b71433634/R/pathways_cbd.R#L1-L77

damianooldoni commented 3 months ago

You are right. I was in that time following rgbif's maintainer, Scott Chamberlain, which was using something similar. But you are right.

PietrH commented 2 months ago

Scott might have a good reason, I'd be interested to know the advantages of doing it this way.

Can we link this issue to a branch or PR? That way we don't lose track.

pathways_cbd perhaps?