search

triat / terraform-security-scan

Run a security scan on your terraform with the very nice https://github.com/aquasecurity/tfsec
MIT License
110 stars 30 forks source link

Github Actions comment is not working well #15

Closed hampton-codes closed 3 years ago

hampton-codes commented 3 years ago

I believe tfsec --no-colour|--no-color should be used to execute in the actions flow so comments can be posted legibly. Currently formatting is unclear making the comment unreadable. Can you add a tfsec_actions_comment_color option and default to false which translates to --no-color? Alternately, it is possible this is not being handled by a header not being set when posting to the comment URL, haven't looked at that.


5 potential problems detected:

�[0m�[0m�[31m�[1m�[4m�[1mProblem 1�[0m�[31m�[1m
�[0m�[0m
  �[34m[�[39mAWS006�[34m]�[39m�[34m[�[39m�[0m�[33mWARNING�[39m�[0m�[34m]�[39m Resource 'aws_security_group_rule.my-rule' defines a fully open ingress security group rule.```
triat commented 3 years ago

Hey @hampton-codes,

Uh nice catch, this is a nasty one. I'll do a quick PR to fix this. Thanks for reporting it.