search

triat / terraform-security-scan

Run a security scan on your terraform with the very nice https://github.com/aquasecurity/tfsec
MIT License
110 stars 30 forks source link

Remove old comment on run? #17

Closed triat closed 3 years ago

triat commented 4 years ago

Should the action remove old comments when it runs again?

I'd like to have your opinion on that.

hampton-codes commented 4 years ago

I vote to leave comment in place. The comment (fyi, looks readable in v2.0.1) is timestamped so there is a history of failure, what failed and potentially a way to realize what was fixed to make it pass. That would be consistent with human feedback as well, I don't think you expect a developer to go back and delete their earlier comment.

triat commented 4 years ago

I vote to leave comment in place. The comment (fyi, looks readable in v2.0.1) is timestamped so there is a history of failure, what failed and potentially a way to realize what was fixed to make it pass. That would be consistent with human feedback as well, I don't think you expect a developer to go back and delete their earlier comment.

Thanks for your feedback. I agree that this is good for the history of the PR but as a developer, you can mark your comments as "resolved" and this will hide most part of it so you'll see only the latest one still open.

hampton-codes commented 4 years ago

I don't have a problem with "resolve" but your question was "remove". I agree that resolving old comment is a good idea.