triat / terraform-security-scan

Run a security scan on your terraform with the very nice https://github.com/aquasecurity/tfsec
MIT License
110 stars 30 forks source link

Updates example to use `v2.0.2` instead of `v1` #22

Closed stefanwb closed 3 years ago

stefanwb commented 3 years ago

Signed-off-by: Stefan Wessels Beljaars swesselsbeljaars@schubergphilis.com

triat commented 3 years ago

Hey @stefanwb,

Thanks for the PR. I'd rather keep it the way it is right now, as it shows an example using a released version. Even if I agree that master should always be production-ready, I'd prefer to keep it on the released version to make sure that people do not get their production down due to a mistake on the branch.

Does this make sense to you?

edit: Would it be possible for you to update the documentation with a v2.x.x tag? (you can put the latest release if you want 👍, thanks)

stefanwb commented 3 years ago

Updated the PR as requested! Could you add the label hacktoberfest-accepted to this PR maybe? :) Thanks!

triat commented 3 years ago

Thanks for the update. I've validated your PR for the hacktoberfest 👍