feat: created footer containing social media details

tribilin-cuba / to-the-rescue

A web service to notify about vulnerable animals in Cuba.

https://tribilin.netlify.app/

MIT License

44 stars 7 forks source link

feat: created footer containing social media details #46

Closed supminn closed 3 years ago

supminn commented 3 years ago

I have created a footer component that contains the details present on the about-us page.

Screenshot:

supminn commented 3 years ago

@amaliaibarra Did you get a chance to view the footer created by me?

amaliaibarra commented 3 years ago

Hi @supminn! Sorry for the late response. Great job! The footer looks great!! But I'm afraid It's more than we expected, this is totally my fault, I should have been more specific in the description.

I'll try to explain it more carefully:

The footer should only contain the links to Instagram, Facebook and GitHub. No other information needed.
It should be fixed in home page, like the Add button.
With background color: rgb(255,250,238)
icons color: #e27e22 and use their rounded version (BsFacebook, BsGitHub, BsInstagram)
The priority is that the footer looks good on mobile phones. Please send a screenshot showing what it would look like.

I'm sorry for the trouble, thank you very much for your hard work!!

amaliaibarra commented 3 years ago

Hi @supminn! Let me know if you are still working on this. Thank you! :)

supminn commented 3 years ago

sure @amaliaibarra @josejorgers, I shall get the changes done on the same PR and update you soon.

amaliaibarra commented 3 years ago

Great!! Thank you very much!! 😊

supminn commented 3 years ago

Hi @amaliaibarra, This is how the footer looks after the changes

I tried to use the rounded version (BsFacebook, BsGitHub, BsInstagram), but for some reason, they were not getting imported from react-icons. Hence I have maintained the previous versions.

amaliaibarra commented 3 years ago

Great job @supminn!! The footer looks amazing. You are our first foreign contributor!! Hooray!! Thank you very much for your collaboration. We really apprecciate it. Keep up the good work :) Happy hacktoberfest!

supminn commented 3 years ago

Thank you @amaliaibarra! I just started out with open source contribution with hacktoberfest 2021. It's really nice to collaborate for a budding project. I look forward to contribute more.

I see that this project is not participating in hacktoberfest-2021, is this for a specific reason?

amaliaibarra commented 3 years ago

Sorry @supmin , we forgot to add the 'hacktoberfest' topic to our repository. I already added it and also the hacktoberfest-accepted label to the PR. Let me know if anything changes. Sorry again.