search

tribut / homeassistant-docker-venv

Run Home Assistant as non-root using the official docker image
123 stars 16 forks source link

Consider moving VENV path under /config #3

Closed dannyk81 closed 4 years ago

dannyk81 commented 4 years ago

Hey @tribut! thanks for sharing this solution, works really well!

I was wondering if it wouldn't be better to define VENV path under /config?

specifically when running HASS in a container, since the default /var/tmp/env is not a persistent path all the packages are lost and have to be reinstalled if the container is restarted.

wdyt?

tribut commented 4 years ago

Hey. Thanks for the feedback!

The first iteration of this script actually had the venv under /config, but I decided that having an ever-growing venv (and the hassle of cleaning it up from time to time) was too much of a burden for the minimal gain of not reinstalling a few packages when HA is upgraded. Additionally, installing the packages "inside" the container most closely resembles what hass.io is doing and is therefore less likely to break.

I've added the possibility to override the location using docker run --env VENV=/config/venv, but I don't think that this is something we should encourage.