fanaticDavid
commented
4 years ago Thank you so much for this script, Chris! Yesterday, I was finally able to update to 0.107.7 (from 0.106.6) using this (not updating to 0.108 just yet).
However, I had to add a little bit of code to make it work in my specific scenario: not only do I avoid running the HA container as root, I also don't connect it to the host network. That creates a problem when trying to use devices (such as Z-Wave and RFLink), but I always managed to work around that with the following snippet in my docker-compose file:
group_add:
- dialoutWhen using this new script, that workaround no longer works and the container has no access to my devices. So now I add an environment variable GROUPADD to my docker-compose file:
environment:
- PUID=${UID}
- PGID=${GID}
- GROUPADD=dialout
- PACKAGES=iputilsAnd my modified run script looks like this:
#!/usr/bin/with-contenv bashio
USER="homeassistant"
PUID="${PUID:-1000}"
PGID="${PGID:-1000}"
GROUPADD="${GROUPADD:-}"
UMASK="${UMASK:-}"
PACKAGES="${PACKAGES:-}"
VENV_PATH="${VENV:-/var/tmp/homeassistant-venv}"
CONFIG_PATH=/config
#
# Creating user
#
# Some HA commands seem to fail if we don't have an actual user.
# ie: shell_command would return error code 255
bashio::log.info "Creating user $USER with $PUID:$PGID"
deluser "$USER" >/dev/null 2>&1 || true
delgroup "$USER" >/dev/null 2>&1 || true
addgroup -g "$PGID" "$USER"
adduser -G "$USER" -D -H -u "$PUID" "$USER"
if [ -n "${GROUPADD}" ]; then
bashio::log.info "Adding extra groups: $GROUPADD"
addgroup "$USER" "$GROUPADD"
fi
#
# Install extra packages
#
if [ -n "${PACKAGES}" ]; then
bashio::log.info "Installing extra packages: $PACKAGES"
apk add --quiet --no-progress --no-cache $PACKAGES
fi
#
# Create virtual environment
#
bashio::log.info "Initializing venv in $VENV_PATH"
su "$USER" \
-c "python3 -m venv --system-site-packages '$VENV_PATH'"
#
# Fix permissions
#
cd "$CONFIG_PATH" || bashio::exit.nok "Can't find config folder: $CONFIG_PATH"
chown -R "$USER:$USER" .
if [ -n "${UMASK}" ]; then
bashio::log.info "Setting umask: $UMASK"
umask "$UMASK"
fi
#
# Run homeassistant
#
.
bashio::log.info "Activating venv"
. "$VENV_PATH/bin/activate"
bashio::log.info "Starting homeassistant"
exec \
s6-setuidgid "$USER" \
python3 -m homeassistant --config "$CONFIG_PATH"I don't know if what I did could've been done any better (as I'm not a developer), but it works for me. It probably wouldn't handle adding multiple groups this way, but I don't have any need for that right now. I'm also not sure if there would be any point in adding this to the PR as I'm aware it's a very specific use case, but I figured I'd share anyway.
Thanks again for your awesome work, Chris! 🙇
Nephiel
Chris-V
tsheeran1
johnluetke
FuzzyMistborn
slamp
tribut
This totally got out of my head :sweat_smile:. I ran this script for almost 2 weeks now without any issues.
This actually replaces the Home Assistant run script with the whole user check, package install and venv management deals. Using S6 this would be preferable to add these things to /etc/cont-init.d/. The current solution is mostly for simplicity and easier end-user setups.
Since it replaces pretty much everything, maybe we could preserve old config formats in a "0.106 and older" directory and these in a "0.107 and newer"?
I notice that Home Assistant added Jemalloc support recently: https://github.com/home-assistant/core/blob/dev/rootfs/etc/services.d/home-assistant/run#L8. This is not included here as this is not yet in a final release. This will require backporting eventually :(
Fixes #5