search

trichards57 / zxcvbn-cs

C#/.NET port of Dan Wheeler/DropBox's Zxcvbn JS password strength estimation library
MIT License
59 stars 19 forks source link

Strong name #18

Closed raandree closed 3 years ago

raandree commented 5 years ago

Thanks for the work on that project. I would like to use the DLL you have provided on NuGet but I need one with strong name support (https://docs.microsoft.com/en-us/dotnet/framework/app-domains/how-to-sign-an-assembly-with-a-strong-name).

Any chance you can add this to your project and publish a new version to NuGet?

I am trying to use your library in ManagedPasswordFilter. As I am calling the .net managed code from C++, the DLL must be signed (at least this is what I have learned). Having all you source code in my project is quite inconvinient.

trichards57 commented 3 years ago

As Microsoft no-longer recommend Strong Names, I will not be fixing this.

trichards57 commented 3 years ago

Re-opened this, as I have re-read the MS guidelines and realised that I misread them.

trichards57 commented 3 years ago

This got fixed by #27