Fixed log base in SequenceMatcher for uppercase sequences.

trichards57 / zxcvbn-cs

C#/.NET port of Dan Wheeler/DropBox's Zxcvbn JS password strength estimation library

MIT License

59 stars 18 forks source link

Fixed log base in SequenceMatcher for uppercase sequences. #19

Closed simchev closed 4 years ago

simchev commented 5 years ago

Looks like there is a small typo in the SequenceMatcher for uppercase entropy calculation. This leads to a NaN entropy for uppercase sequences, and they're simply ignored in the match selection (FindMinimumEntropyMatch).

simchev commented 5 years ago

Not exactly sure why it doesn't want to merge, but it's possible since I forked from the original version. I just wanted to fix it here since it looks like this fork is more maintained.

trichards57 commented 4 years ago

Thanks for the input. I think this has been resolved by #22, so I won't be merging it in for the moment.