Feedback logic error fixed #29

trichards57 / zxcvbn-cs

C#/.NET port of Dan Wheeler/DropBox's Zxcvbn JS password strength estimation library

MIT License

59 stars 18 forks source link

Closed RPScylla closed 2 years ago

RPScylla commented 3 years ago

currently the check if dictionary name is surnames eg happens inside the if statement that checks if the name is password

this means lines 78-88 of Feedback.cs are unreachable. Fixes #29

tmijieux commented 3 years ago

i did not read this ahead and actually file another pull request that fix that very same bugs among two others... oops