codecov-io commented 5 years ago

Codecov Report

Merging #14 into master will not change coverage. The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #14   +/-   ##
=======================================
  Coverage   90.33%   90.33%           
=======================================
  Files          17       17           
  Lines        1946     1946           
=======================================
  Hits         1758     1758           
  Misses        188      188

Impacted Files	Coverage Δ
rf/imaging.py	`94.63% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 06d02b1...ba3a31f. Read the comment docs.

trichter commented 5 years ago

Thanks for this addition. I would rather prefer to not use **kwargs for this purpose. Do you have the dpi option in mind? Then I think it is better to add this option directly to plot_rf and plot_profile.

If the user needs more customization he can use a matplotlibrc file or code like

fig = stream.plot_rf()
fig.savefig(...)

medlin01GA commented 5 years ago

Hmm, your suggestion of the end-user calling savefig on the figure is probably a better approach than this PR, otherwise it is a slippery slope of custom options for the user and the rf API could bloat. dpi was the only option I had in mind for my personal use case.

trichter commented 5 years ago

For convenience, I added the dpi option.

trichter / rf

Andrew medlin/13 plot rf allows kwargs #14

Codecov Report