trichter / rf

Receiver function calculation in seismology
MIT License
106 stars 62 forks source link

Add iterative deconvolution option #30

Closed hfmark closed 3 years ago

hfmark commented 3 years ago

I also added a link to another example jupyter notebook comparing deconvolution methods

codecov-io commented 3 years ago

Codecov Report

Merging #30 (f2fb30f) into master (00be998) will increase coverage by 0.35%. The diff coverage is 97.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
+ Coverage   90.71%   91.07%   +0.35%     
==========================================
  Files          17       17              
  Lines        1982     2061      +79     
==========================================
+ Hits         1798     1877      +79     
  Misses        184      184              
Impacted Files Coverage Δ
rf/__init__.py 85.71% <ø> (ø)
rf/deconvolve.py 89.28% <97.50%> (+5.28%) :arrow_up:
rf/tests/test_deconvolve.py 98.23% <100.00%> (+0.08%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 00be998...f2fb30f. Read the comment docs.

trichter commented 3 years ago

Excellent. Thanks a lot. I will have a look and push some tweaks soonish.

trichter commented 3 years ago

I basically tried to unify some code between deconvf and deconv_iter.

Please check my changes. You can check the ci tests here: https://travis-ci.org/github/trichter/rf/branches. (These test results used to be displayed directly here at github, I guess I have to move the testing to github actions.)

Ideally, would be a test for S-receiver functions for the different deconvolution functions, but I guess this is not urgent.

Feel free to push the merge button once the tests above give green light.

hfmark commented 3 years ago

The changes look good - thanks for neatening it up! Looks like the tests are ok, so I'll merge it and see about adding the multitaper decon next week sometime.