search

triciiaaa / pe

0 stars 0 forks source link

No error message for Invalid email address #2

Open triciiaaa opened 4 months ago

triciiaaa commented 4 months ago

Description

The email provided is missing a period but the application does not throw an error when the incorrect email format is being added.

Steps to reproduce

  1. input add n/Benny Doe p/98765432 e/johnd@examplecom m/Computer Science

Expected

Error message should be thrown with regards to the invalid email.

Actual

Contact of the person is being added successfully.

Screenshots

image.png

nus-pe-script commented 4 months ago

Team's Response

Hey, thanks for raising this.

However we are already considering local@domain.com style email validation as part of our Planned Enhancements.

image.png

We'd also like to point out that you can have dotless domain names too.

Souce: https://www.netmeister.org/blog/email.html

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]