soc-pe-bot
commented
1 year ago Team's Response
You've mentioned that this is inaccurate because empty skills or modules are not allowed, but we are unsure how you pick that up because we have never mentioned those in UG/DG. In fact, these are allowed and valid inputs of a user. Furthermore, this is not an error message for duplicate person, that is also handled separately with another error message.
Behavior:
This message is returned when the edits users made has resulted in no change of a person. This command will be used when user wants to add no modules/skills to a person for some reason, or when user has accidentally left out a field. As a result, no change was made and error message is displayed as shown.
Reasoning:
User expects no change to be made, or command to fail if one had accidentally left a parameter out. Program does function as intended and throws the correct error message.
Though the behavior is as expected, we agree that the error message may not have been very explicit about the edit command failing because no changes will be made. This made you believe that the error message is the one for "duplicate person" when in fact it was for "no changes made".
The behavior is as expected and will not cause any inconvenience to users, but since we do understand that the error message could have been better phrased, we have accepted this bug with a lowered severity.
Please let us know if you as a user were expecting another kind of behavior or disagree about its functionality.
Items for the Tester to Verify
:question: Issue severity
Team chose [severity.VeryLow]
Originally [severity.Low]
- [x] I disagree
Reason for disagreement: should not be very low as it is not just a cosmetic issue
Inaccurate error message when editing details using the s+/ s-/ m+/ m-/ edit prefixes.
This message can be replicated by using any of the prefixes s+/ s-/ m+/ m-/ with an empty string after.
The error message shows "The person already has these attributes" Which is inaccurate, this is because empty skills or modules are not allowed. Hence, adding an empty string as a module or skill should not give the error of duplicate.
This could be due to the internal backend searching function when checking for existing skills and modules
This feature can cause confusion to the user as behaviour differs from the normal expectation (error message does not match the error)