tricixg / pe

0 stars 0 forks source link

Incorrect error message for duplicate emails #5

Open tricixg opened 1 year ago

tricixg commented 1 year ago

Behavior is not specified and differs from normal expectations (error message does not match the error)

to duplicate this, 1) have a contact with the email e0823741@u.nus.edu 2) add another contact with the same email as well as an incorrect prefix m+/

The error message that shows up is regarding an error in the format of the email instead of the email being a duplicate. Additionally, the m+/ prefix is incorrectly used and is not allowed in the add command. This error is also not specified in the error message.

This could lead to confusion by the user and makes it hard for the user to learn how to use the software properly

Screenshot 2023-04-14 at 2.58.45 PM.png

Screenshot 2023-04-14 at 2.58.58 PM.png Screenshot 2023-04-14 at 2.59.08 PM.png Screenshot 2023-04-14 at 2.59.17 PM.png

nus-pe-script commented 1 year ago

Team's Response

Error message not well defined and we forgot to consider this

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

incorrect error message when using wrong prefix

to duplicate, 1) add a new contact, with a valid email however use the prefix m+/ which is not allowed.

The error message displayed is regarding the email format. However, there is no issue with the email format.

This could lead to confusion as Behavior is not specified and differs from normal expectations (error message does not match the error)

Screenshot 2023-04-14 at 3.04.53 PM.png


[original: nus-cs2103-AY2223S2/pe-interim#3952] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thanks for the find, we missed this edge case where the user uses a wrong prefix

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]