search

tricixg / pe

0 stars 0 forks source link

Module code input constraint not documented #8

Open tricixg opened 1 year ago

tricixg commented 1 year ago

There is no constraint on the format of the module code documented. However, the software rejects module code of only numbers without any alphabet at the start of the code. eg. 23h3h32 - rejected c32233 - accepted 23423 - rejected

This should be documented in the UG to avoid confusion

Screenshot 2023-04-14 at 3.17.36 PM.png

nus-pe-bot commented 1 year ago

Team's Response

Hi, thank you for your suggestion but this should not be classified under medium severity as per guidelines due to the NUS guidelines on module naming.

Screenshot 2023-04-15 at 12.37.34 PM.png Screenshot 2023-04-16 at 10.26.53 AM.png

Also, our application already shows the appropriate prompt for said scenarios... Screenshot 2023-04-16 at 10.27.20 AM.png

It does not follow the philosophy of this module in regards to what to put in a UG Screenshot 2023-04-16 at 10.20.45 AM.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: module code of more than 4 numbers were accepted

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]