Open hwwan80 opened 9 years ago
I do not own a Windows machine and can't fix this issue. Any help here would be welcome.
http://www.ember-cli.com/#symlinks-on-windows says it's an access control policy issue, i.e. run as admin, or failing that have the plugin fall back on copying files when symlinking isn't available.
@nruth this issue has nothing to do with ember-cli
The issue here is that windows doesn't support symlinks in the same way. See my PR #136 which solves this issue (based on my tests) using the mklink
windows command.
@rwz OK, I'll leave you to it then.
I can create a branch and start working on windows support. However I need people to voluntarily help me testing it since I don't own a Windows machine.
I want to volunteer for testing on Windows.
I am currently using it and had to make changes to ember-cli-rails-0.3.5 to make it work on Windows.
I had to implement #114 with a change to ember-cli\app_win.rb OLD:
@ember_path ||= app_path.join
NEW:
ember_path ||= Rails.root.join
I also had change to the ember-cli\runner.rb because Process.getpgid is not supported on Windows. OLD:
def still_running? Process.getpgid app.pid true rescue Errno::ESRCH # no such process false end
NEW:
def still_running? Process.kill 0, app.pid true rescue TypError #Errno::ESRCH - no such process, Errne::EPERM false end
We're sorry that this issue has sat for so long.
The project is now maintained by thoughtbot, and we're declaring an issue bankruptcy of sorts.
We're closing this issue. If what you've described is still a problem, please comment on this issue and we'll reopen.
@JanJacobs those changes look promising, would you mind opening a PR to help with windows support?
Thanks for your patience.
:+1: Still have this problem on windows 7 using Rails 4.2.4 and ember-cli-rails 0.5.3 with corresponding ember-cli-rails-addon
Would anyone still seeing this problem pleae try out:
ember-cli-rails
gemember-cli-rails-addon
Each of those branches has up-to-date README's.
Unfortunately I still get the symlink() function is unimplemented on this machine
error.
Gemfile:
source 'https://rubygems.org'
gem 'ember-cli-rails', git: 'git@github.com:thoughtbot/ember-cli-rails.git'
# Bundle edge Rails instead: gem 'rails', github: 'rails/rails'
gem 'rails', '4.2.4'
# Use sqlite3 as the database for Active Record
gem 'sqlite3'
# Use SCSS for stylesheets
gem 'sass-rails', '~> 5.0'
# Use Uglifier as compressor for JavaScript assets
gem 'uglifier', '>= 1.3.0'
# Use CoffeeScript for .coffee assets and views
gem 'coffee-rails', '~> 4.1.0'
# Use jquery as the JavaScript library
gem 'jquery-rails'
# Turbolinks makes following links in your web application faster. Read more: https://github.com/rails/turbolinks
gem 'turbolinks'
# Build JSON APIs with ease. Read more: https://github.com/rails/jbuilder
gem 'jbuilder', '~> 2.0'
# bundle exec rake doc:rails generates the API under doc/api.
gem 'sdoc', '~> 0.4.0', group: :doc
group :development, :test do
# Call 'byebug' anywhere in the code to stop execution and get a debugger console
gem 'byebug'
end
group :development do
# Access an IRB console on exception pages or by using <%= console %> in views
gem 'web-console', '~> 2.0'
end
# Windows does not include zoneinfo files, so bundle the tzinfo-data gem
gem 'tzinfo-data', platforms: [:mingw, :mswin, :x64_mingw, :jruby]
and package.json from ember:
{
"name": "frontend",
"version": "0.0.0",
"description": "Small description for frontend goes here",
"private": true,
"directories": {
"doc": "doc",
"test": "tests"
},
"scripts": {
"build": "ember build",
"start": "ember server",
"test": "ember test"
},
"repository": "",
"engines": {
"node": ">= 0.10.0"
},
"author": "",
"license": "MIT",
"devDependencies": {
"broccoli-asset-rev": "^2.1.2",
"ember-cli": "1.13.8",
"ember-cli-app-version": "0.5.0",
"ember-cli-babel": "^5.1.3",
"ember-cli-content-security-policy": "0.4.0",
"ember-cli-dependency-checker": "^1.0.1",
"ember-cli-htmlbars": "0.7.9",
"ember-cli-htmlbars-inline-precompile": "^0.2.0",
"ember-cli-ic-ajax": "0.2.1",
"ember-cli-inject-live-reload": "^1.3.1",
"ember-cli-qunit": "^1.0.0",
"ember-cli-rails-addon": "git+https://github.com/rondale-sc/ember-cli-rails-addon.git#a5d2cf050dce8d943f1eced990a535a8f6e7ac11",
"ember-cli-release": "0.2.3",
"ember-cli-sri": "^1.0.3",
"ember-cli-uglify": "^1.2.0",
"ember-data": "1.13.8",
"ember-disable-proxy-controllers": "^1.0.0",
"ember-export-application-global": "^1.0.3"
}
}
Running on 64-bit Windows 7 Professional Service Pack 1
I implemented the changes from swelham "The issue here is that windows doesn't support symlinks in the same way. See my PR #136 which solves this issue (based on my tests) using the mklink windows command."
Additionally I had to make the following changes
_ember-cli\appwin.rb OLD:
@ember_path ||= app_path.join
NEW:
ember_path ||= Rails.root.join
I also had change to the ember-cli\runner.rb because Process.getpgid is not supported on Windows. OLD:
def still_running? Process.getpgid app.pid true rescue Errno::ESRCH # no such process false end
NEW:
def still_running? Process.kill 0, app.pid true rescue TypError #Errno::ESRCH - no such process, Errne::EPERM false end
I using 64-bit Windows 10 Pro.
@wjdhamilton it sounds like you're running off of master
.
To run the branches I suggested, you'll need to modify your Gemfile
and Ember's package.json
:
# Gemfile
gem 'ember-cli-rails', github: 'thoughtbot/ember-cli-rails', branch: 'remove-sprockets'
{
"devDependencies": {
"ember-cli-rails-addon": "rondale-sc/ember-cli-rails-addon#remove-sprockets",
}
}
@JanJacobs thanks for sharing those Windows fix proposals.
Unfortunately, I don't have access to a Windows machine to verify their validity.
There is a branch that introduces AppVeyor for CI testing:
https://github.com/thoughtbot/ember-cli-rails/pull/291
Would you mind helping to create windows versions of:
bin/setup
-
ember-cli-rails-addon@rondale-sc/ember-cli-rails-addon
in that Ember repo
*runs rake ember:install
bin/setup_ember
-
Once we have setup parity across platforms, we can start to ensure the Windows version behaves the same as other Operating Systems versions.
I want to help, yes please. Just a bit crazy at the office at the moment, by next week most of SA is on holiday and then I can get some work done:))
@seanpdoyle I've just tried a fresh app with the two links that you suggested, however the app now reports: No
ember-cliexecutable found for
frontend. Install it: $ cd C:/sites/ember-cli-rails-windows-test/frontend $ npm install
. I have definitely run npm install in frontend.
@wjdhamilton did you ever find the solution to this problem? I'm trying to hand over an app I wrote on a Mac to a Windows dev and he is getting the same error, been stuck on this for ages!
Unfortunately not - I bought a mac when Rails stopped working properly on Windows and never looked back! On 15 Aug 2016, at 08:08, Grant van Helsdingen notifications@github.com<mailto:notifications@github.com> wrote:
@wjdhamiltonhttps://github.com/wjdhamilton did you ever find the solution to this problem? I'm trying to hand over an app I wrote on a Mac to a Windows dev and he is getting the same error, been stuck on this for ages!
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/thoughtbot/ember-cli-rails/issues/114#issuecomment-239741676, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AHJwKp70sUxUW4vyKz7kLKMKNOJrPxVEks5qgBBrgaJpZM4Dv1hL.
@1vanhelsing1 if you're still trying to hand this over to a windows dev, as of the 14942 build of the win 10 insider preview, you can now use ember-cli in windows bash.
I recommend having that be the official answer and close this issue.
When I try to use ember-cli-rails in windows, the following exception error when visit the url:
Running in Windows 7 Enterpise with administrator right