search

tricknotes / ember-cli-rails

Unify your EmberCLI and Rails Workflows
http://thoughtbot.github.io/ember-cli-rails/
MIT License
713 stars 205 forks source link

Ignore requests for /rails/info routes #449

Closed stevenharman closed 8 years ago

stevenharman commented 8 years ago

When mounting an Ember CLI app via mount_ember_app, the catch-all routes defined by Ember CLI Rails also catch requests to two of Rails' magic routes:

  1. /rails/info/routes (which is also redirected to from /rails/info)
  2. /rails/info/properties

This adds another constraint to the mounted Ember app that will ignore requests with a path starting with /rails/info. I'm not in love with this solution, and basically hacked it together to see if it's even functionality you'd like added to the gem. If so, we can work to clean up the implementation, add documentation, etc... If not, perhaps we can simply document this in the README and maybe include the constraint so others can apply it if they wish.

Let me know what I can do to help.

seanpdoyle commented 8 years ago

@stevenharman sorry that this PR has sat for so long.

I think master is green once again, would you mind rebasing and pushing to get CI passing?

stevenharman commented 8 years ago

@seanpdoyle I've rebased the PR. Are there any changes you'd like me to make? I'm sure the naming could use some improvement. I didn't put too much effort into the initial PR as I wasn't sure this was something you'd want in the project.

I'm happy to make any changes you see fit.

seanpdoyle commented 8 years ago

Thanks for opening this PR and submitting this code.

You've inspired me to try and address the problem myself in a separate PR.

Could you provide some feedback on https://github.com/thoughtbot/ember-cli-rails/pull/471?

seanpdoyle commented 8 years ago

Closing in favor of https://github.com/thoughtbot/ember-cli-rails/pull/471#issuecomment-231433077.

Thanks @stevenharman!