search

tricknotes / ember-cli-rails

Unify your EmberCLI and Rails Workflows
http://thoughtbot.github.io/ember-cli-rails/
MIT License
713 stars 205 forks source link

ember cli-rails as dependency rather than a devDependency? #506

Closed stripedpumpkin closed 7 years ago

stripedpumpkin commented 7 years ago

Wondering why

heroku config:set NPM_CONFIG_PRODUCTION=false

Would there be an issue separating devDependencies from Dependencies and treating ember-cli-rails as a normal dependency (and leaving the heroku flag at true)? In general there could be a few devDependencies that need not be included in the prod build.

seanpdoyle commented 7 years ago

Unfortunately, this was a workaround to ensure that npm installed node_modules/ember-cli/bin/ember, so that the EmberCLI process had access to the executable.

The code that requires this hasn't changed in almost a year, which is eons in JS-time.

Do you know if newer versions of NPM require a similar workaround?

seanpdoyle commented 7 years ago

@stripedpumpkin you are correct, bower should be declared as a dependencies value, not a devDependencies value in the root level package.json.

The original suggestion stems from a misunderstanding of how NPM managed local executables.

I'm closing this for now, and will follow it up with a change to the documentation.

THANK YOU!

seanpdoyle commented 7 years ago

@stripedpumpkin related: https://github.com/thoughtbot/ember-cli-rails/pull/507