Patch Rails 5.1 not supporting text option for render anymore

tricknotes / ember-cli-rails

Unify your EmberCLI and Rails Workflows

http://thoughtbot.github.io/ember-cli-rails/

MIT License

713 stars 205 forks source link

Patch Rails 5.1 not supporting text option for render anymore #519

Closed weggesser closed 7 years ago

weggesser commented 7 years ago

Ran into an exception while trying to use this with rails 5.1 - :text option is no longer supported by ActionView:: TemplateRenderer

wireframe commented 7 years ago

@seanpdoyle any blockers to merging this in? Rails 5.1 has hit release candidate and it would be awesome to have a ember-cli-rails release w/ compatibility on day one if possible.

seanpdoyle commented 7 years ago

@wireframe CI is failing, but it looks like it might be unrelated.

Once it's green, we can merge.

seanpdoyle commented 7 years ago

Unfortunately, I've been unable to correct the issues with CI failing.

I've tested this change manually and it's good to go, and has been merged in https://github.com/thoughtbot/ember-cli-rails/commit/585cfea9231232baee544d2402e5c88f12edf0bb.