search

tricknotes / ember-cli-rails

Unify your EmberCLI and Rails Workflows
http://thoughtbot.github.io/ember-cli-rails/
MIT License
713 stars 205 forks source link

Rails 5.1.0 removed "render text: ..." #527

Closed d-schloss-mvg closed 7 years ago

d-schloss-mvg commented 7 years ago

Which version of ruby is the project developed on? ruby-2.2.3

What is the rails version? 5.1.0

What is the ember-cli-rails version (from Gemfile)? 0.8.4

What is the ember-cli-rails-addon version (from package.json)? ~> 0.8.0 resolved to 0.8.0

What are the contents of the Rails' view that renders the Ember application? Default

How are the EmberCLI-related routes defined? via mount_ember_app.

Running a (empty/default) ember-cli-rails project yields the error:

You invoked render but did not give any of :partial, :template, :inline, :file, :plain, :html or :body option.

referencing this line: https://github.com/thoughtbot/ember-cli-rails/blob/v0.8.4/app/helpers/ember_rails_helper.rb#L11

According to Rails CHANGELOG this was removed in 5.1.0: https://github.com/rails/rails/blob/v5.1.0.rc1/actionpack/CHANGELOG.md "Remove deprecated support to :text in render."

The new way would be :plain instead of :text. (Which exists since Rails 4.1 ? I am not sure about this though...) as discussed here: http://stackoverflow.com/questions/43428991/what-to-use-instead-of-render-text-in-rails-5-1-and-later

seanpdoyle commented 7 years ago

Fixed by 0.8.5.