search

tricknotes / ember-cli-rails

Unify your EmberCLI and Rails Workflows
http://thoughtbot.github.io/ember-cli-rails/
MIT License
713 stars 205 forks source link

Make `bower` an optional dependency #532

Closed seanpdoyle closed 7 years ago

seanpdoyle commented 7 years ago

Closes #531.

According to bower warning messages, the project is semi-deprecated:

While Bower is maintained, we recommend Yarn and Webpack for *new*
front-end projects! Yarn's advantage is security and reliability, and
Webpack's is support for both CommonJS and AMD projects. Currently
there's no migration path but we hope you'll help us figure out one.

As such, the build process will skip bower install and won't require a bower if the application's bower.json file is missing.

mike-burns commented 7 years ago

Words seem right, code seems right.

jdurand commented 7 years ago

This just broke my Semaphore CI build with the following even though I have bower.json in my ember.js projects.

Missing bower packages: 

[...]

Run `bower install` to install missing dependencies.

Since this is a breaking change, shouldn't it have been part of a minor version bump?

seanpdoyle commented 7 years ago

@jdurand could you try CI again, depending on gem "ember-cli-rails", github: "thoughtbot/ember-cli-rails", branch: "revert-34ff6dd" (https://github.com/thoughtbot/ember-cli-rails/pull/535).

If that succeeds, we'll publish a bugfix version for0.8.x, and bring forward 0.8.6's changes to 0.9.0.

jdurand commented 7 years ago

Yes, revert-34ff6dd fixes the build.

Note that I was able to fix this by running bower install as a postinstall script:

//package.json
{
  "scripts": {
    "postinstall": "bower install"
  }
}

This could be the 0.9.x way to go as long as it's mentioned in the README and/or CHANGELOG.