Open hoopsphere opened 7 years ago
Would appreciate if someone could help me out!
Not an expert but you're using npm version 5.0.3 when you develop and Heroku says Using default npm version: 3.10.10
.
In addition, Heroku says:
remote: Some possible problems:
remote:
remote: - Node version not specified in package.json
remote: https://devcenter.heroku.com/articles/nodejs-support#specifying-a-node-js-version
Have you followed this tip?
Also, can you share the content of sh bin/heroku_install
?
remote: bower ENOENT No bower.json present
Seems to be the problematic line of logging output.
https://github.com/thoughtbot/ember-cli-rails/pull/532 added support for skipping bower install
when bower.json
is absent.
Unfortunately, that commit did not modify the generated heroku_install.sh
script.
Does your project have a bower.json
file?
If not, could you try removing any bower
-related lines from your bin/heroku_install.sh
file?
@hoopsphere was this issue closed intentionally?
Did removing the bower-related lines resolve your build errors?
Hey @seanpdoyle. Just deployed my ember-cli-app today and ran into the same issues. I had to go in there and remove the bower-related lines.
Wondering if something could be done about this (eg; for a different heroku_install.sh
template to be run if a bower.json
file isn't detected in the app || some documentation).
not sure if its relevant but I just uploaded a new project to heroku and it was failing @ running the heroku_install.sh
file. I connected to the box via heroku run bash
and then checked the contents of /bin
and the file is not there. Check contents of my .gitignore
and /bin
isnt ignored. Wondering why the file isnt getting there.
@getaclue did you run the ember:heroku generator?
There are some issues with the way Heroku setup currently works. We're actively working Heroku setup to remove the bash script and no longer rely on NPM's postinstall
hook.
@seanpdoyle I did -- also ended up just rewriting the postinstall script using inline with the commands that were in that file... and it ran fine. So that's fine for now.
I'm not sure if my problem (I tried to reach out to you on ember's Slack) is related to this or something else. My ember's image assets are not being moved to public folder from the /tmp. Tried to follow https://github.com/thoughtbot/ember-cli-rails/issues/30 but didn't see a solution that worked for me. Currently reading your code-base to see where the cp
function is being ran to see why my images are not being carried over.
(and I'm not using a cdn... just wanting it served via Rails I should add)
Just thought I'd comment that things seem to be working OK now with the latest release?
heroku deploy is working well for us in production with the new gem release, with various combinations of yarn/npm, bower/no-bower, and the bin/heroku_install script deleted.
Images are working fine for us too with ember-cli and rootURL settings.
Which operating system and version is the project developed on? Mac OS Sierra 10.12.5 Which version of
ruby
is the project developed on? ruby 2.4.0p0 (2016-12-24 revision 57164) [x86_64-darwin16] Which version ofnpm
is the project developed on? 5.0.3 Which version ofember-cli
is the project developed on? 2.13.2 What is therails
version? 5.1.1 What is theember-cli-rails
version (fromGemfile
)? 0.9.0 What is theember-cli-rails-addon
version (frompackage.json
)? 0.8.0 Is your application server multi-threaded (such aspuma
andunicorn
) or is it multi-process (such as thin and webrick)? Don't know What are the contents ofconfig/initializers/ember.rb
?What are the contents of the Rails' view that renders the Ember application? Not sure what this means How are the EmberCLI-related routes defined?
How is the application deployed? Trying to deploy on Heroku
I followed the steps religiously at https://github.com/thoughtbot/ember-cli-rails/ but unable to deploy even a sample app.
At that point, I started following step by step, starting with adding the gem 'ember-cli-rails.'
I also created a heroku app
However, I am unable to push to Heroku. I get this error stack:
These are some of the fixes I have tried but failed with:
*
In ./package.json, modifysh bin/heroku_install
to./bin/heroku_install
*
In https://github.com/seanpdoyle/ember-cli-rails-heroku-example, he suggests running generator usingrails g ember-cli:heroku
but theember-cli:heroku
command is not even recognized; terminal recommends usingember:heroku
so that was a dead end as well.I built the heroku webpacks as such:
Here is what my
reg2/package.json
(root package.json) looks like:Here is the one in the ember frontend app (
reg2/frontend/package.json
):Been banging my head against this for a couple days now; would REALLY appreciate your help!