Recognize Building notice as not an error

tricknotes / ember-cli-rails

Unify your EmberCLI and Rails Workflows

http://thoughtbot.github.io/ember-cli-rails/

MIT License

713 stars 205 forks source link

Recognize Building notice as not an error #577

Closed kobsy closed 2 years ago

kobsy commented 5 years ago

Newer versions of ember-cli seem to be putting a progress spinner with - Building on stderr, which ember-cli-rails doesn't recognize as not a BuildError. This adds a simple regex to detect--and ignore--this output.

seanpdoyle commented 4 years ago

We've recently switched continuous integration providers for this project. To re-run your pull request's test suite, could you rebase off of the latest master branch and force push this PR's branch?

kobsy commented 4 years ago

I rebased as asked, but now there are a few houndci-bot comments. I have no problem addressing the style issues as indicated, but I also note that it would make the style inconsistent with the rest of the respective files. Should I change them or leave them as-is?

romaingweb commented 3 years ago

Hi folks! Is there anything that prevents this PR to be merged and released? Anything I can help with?