search

tricknotes / ember-cli-rails

Unify your EmberCLI and Rails Workflows
http://thoughtbot.github.io/ember-cli-rails/
MIT License
713 stars 205 forks source link

Fix autoload deprecation in Rails 6 #580

Closed f1sherman closed 4 years ago

f1sherman commented 4 years ago

After upgrading an application to Rails 6, I noticed the following deprecation warning:

DEPRECATION WARNING: Initialization autoloaded the constants ApplicationController

This appears to be due to the initializer requiring EmberController, which shouldn't be necessary since that class is already in app/controllers, which is autoloaded. Similarly EmberRailsHelper is autoloaded and shouldn't need to be referenced here.

I wasn't able to run the specs as I'm getting a SystemStackError: stack level too deep when running bin/setup, which I'm also seeing on the master branch. Let me know if that's a known issue or if you'd like more info on that.

seanpdoyle commented 4 years ago

We've recently switched continuous integration providers for this project. To re-run your pull request's test suite, could you rebase off of the latest master branch and force push this PR's branch?

seanpdoyle commented 4 years ago

I've rebased this branch off master and have opened https://github.com/thoughtbot/ember-cli-rails/pull/587 in place of this PR.