search

tricknotes / ember-cli-rails

Unify your EmberCLI and Rails Workflows
http://thoughtbot.github.io/ember-cli-rails/
MIT License
713 stars 205 forks source link

Support Ruby 3.0.0 #591

Closed tricknotes closed 2 years ago

tricknotes commented 3 years ago

This PR fixes ember-cli-rails to work on Ruby 3.0.0.

This is a release note https://www.ruby-lang.org/en/news/2020/12/25/ruby-3-0-0-released/

Ruby 3.0.0 has some breaking changes like the following:

This PR follows up them to work with current support Ruby versions including 3.0.0.

Without this change, booting ember-cli-rails fails by the following error.

/bundle/ruby/3.0.0/gems/ember-cli-rails-0.11.0/lib/ember_cli/app.rb:11:in `initialize': wrong number of arguments (given 2, expected 1) (ArgumentError)
    from /bundle/ruby/3.0.0/gems/ember-cli-rails-0.11.0/lib/ember_cli/configuration.rb:11:in `new'
    from /bundle/ruby/3.0.0/gems/ember-cli-rails-0.11.0/lib/ember_cli/configuration.rb:11:in `app'
tricknotes commented 3 years ago

@seanpdoyle Could you review this PR ?

WozniakMac commented 3 years ago

@seanpdoyle @rondale-sc Hi guys. Any updates on this?

mileslane commented 2 years ago

Please make a release that includes this code!