search

tricknotes / ember-cli-rails

Unify your EmberCLI and Rails Workflows
http://thoughtbot.github.io/ember-cli-rails/
MIT License
713 stars 205 forks source link

Allow ember-cli-rails-assets < 1.0 #599

Closed tricknotes closed 1 year ago

tricknotes commented 1 year ago

It will be release in https://github.com/seanpdoyle/ember-cli-rails-assets/pull/18.

seanpdoyle commented 1 year ago

@tricknotes I've pinged you on https://github.com/seanpdoyle/ember-cli-rails-assets/pull/18#issuecomment-1425884550, but you might not've received a notification since it's a different repository.

tricknotes commented 1 year ago

@seanpdoyle Oh, I'm sorry for miss your comment. I just find a solution for failure of https://github.com/seanpdoyle/ember-cli-rails-assets/pull/18.

This is a dependency issue. Since ember-cli-rails restricts only ember-cli-rails-assets 0.6.x, ember-cli-rails-assets wouldn't match released any versions of ember-cli-rails. https://github.com/thoughtbot/ember-cli-rails/blob/v0.12.0/ember-cli-rails.gemspec#L18

A new version of ember-cli-rails with this change will fix CI of https://github.com/seanpdoyle/ember-cli-rails-assets/pull/18.

To make ready this PR, I fixed rails main CI in https://github.com/thoughtbot/ember-cli-rails/pull/601.

Could you review all of them?

tricknotes commented 1 year ago

Thanks for merge https://github.com/thoughtbot/ember-cli-rails/pull/601, @seanpdoyle ! I rebased this PR. Please wait a minutes to pass all of CIs.