trickstercache / trickster

Open Source HTTP Reverse Proxy Cache and Time Series Dashboard Accelerator
https://trickstercache.org
Apache License 2.0
1.98k stars 177 forks source link

Clickhouse fix #698

Closed jnichols-git closed 6 months ago

jnichols-git commented 8 months ago

Issue 696 was describing an issue with multi-line queries in ClickHouse, where if a query started with SELECT immediately followed by a newline, it would not get cached. The parser previously only looked for SELECT or SELECT (including spaces), so this adds SELECT\n to the list. Also removed a make call that was unused.

coveralls commented 7 months ago

Pull Request Test Coverage Report for Build 7851474734


Files with Coverage Reduction New Missed Lines %
pkg/cache/filesystem/filesystem.go 3 97.93%
pkg/cache/bbolt/bbolt.go 4 88.55%
<!-- Total: 7 -->
Totals Coverage Status
Change from base Build 7109829312: -0.04%
Covered Lines: 17285
Relevant Lines: 18732

💛 - Coveralls
jnichols-git commented 7 months ago

Runners are really struggling today... Ready for review.